Code review comment for lp:~sinzui/launchpad/latest-release-portlet-bug-424893

Revision history for this message
Curtis Hovey (sinzui) wrote :

This is my branch to remove the latest release portlet from the dsp index.

    lp:~sinzui/launchpad/latest-release-portlet-bug-424893
    Diff size: 54
    Launchpad bug: https://bugs.launchpad.net/bugs/424893
    Test command: ./bin/test -vvt "xx-distribution-packages"
    Pre-implementation: geser (Michael Bienia).
    Target release: 3.1.11

= Remove the latest release portlet from the dsp index =

https://edge.launchpad.net/ubuntu/+source/mysql-dfsg-5.1
This page says "Uploaded by Dave Walker" ... however, the .dsc file
disagrees with this, and says that it's uploaded by Mario Limonciello
...
As seen on https://edge.launchpad.net/ubuntu/+source/kde4libs the "Latest
release" doesn't list the latest version in the development version but
instead the most recent upload to any pocket (here jaunty-backports) making
this portlet even more useless.

Summary: We know the portlet is wrong because the content inline contradicts
it. The packages for a DSP happen in paralell series, as the page shows; the
portlet can never be 100% right.

== Rules ==

    * Remove the portlet since the correct information is inline.

== QA ==

    * Visit https://edge.launchpad.net/ubuntu/+source/kde4libs
    * Verify that there is no latest release port among the side portlets.

== Lint ==

Linting changed files:
  lib/lp/registry/stories/distribution/xx-distribution-packages.txt
  lib/lp/registry/templates/distributionsourcepackage-index.pt

== Test ==

Describe test additions, changes, and even tests that must run unchanged.

    * lib/lp/registry/stories/distribution/xx-distribution-packages.txt
      * Deleted the test for the portlet

== Implementation ==

    * lib/lp/registry/templates/distributionsourcepackage-index.pt
      * Deleted the inlined portlet.

« Back to merge proposal