Launchpad itself

Merge lp:~sinzui/launchpad/latest-release-portlet-bug-424893 into lp:launchpad

  1. latest-release-portlet-bug-424893
  2. Merge into devel
Proposed by Curtis Hovey
Status: Merged
Approved by: Barry Warsaw
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~sinzui/launchpad/latest-release-portlet-bug-424893
Merge into: lp:launchpad
Diff against target: 83 lines (+9/-25)
2 files modified
lib/lp/registry/stories/distribution/xx-distribution-packages.txt (+2/-8)
lib/lp/registry/templates/distributionsourcepackage-index.pt (+7/-17)
To merge this branch: bzr merge lp:~sinzui/launchpad/latest-release-portlet-bug-424893
Reviewer Review Type Date Requested Status
Barry Warsaw (community) code Approve
Review via email: mp+14565@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :

This is my branch to remove the latest release portlet from the dsp index.

    lp:~sinzui/launchpad/latest-release-portlet-bug-424893
    Diff size: 54
    Launchpad bug: https://bugs.launchpad.net/bugs/424893
    Test command: ./bin/test -vvt "xx-distribution-packages"
    Pre-implementation: geser (Michael Bienia).
    Target release: 3.1.11

= Remove the latest release portlet from the dsp index =

https://edge.launchpad.net/ubuntu/+source/mysql-dfsg-5.1
This page says "Uploaded by Dave Walker" ... however, the .dsc file
disagrees with this, and says that it's uploaded by Mario Limonciello
...
As seen on https://edge.launchpad.net/ubuntu/+source/kde4libs the "Latest
release" doesn't list the latest version in the development version but
instead the most recent upload to any pocket (here jaunty-backports) making
this portlet even more useless.

Summary: We know the portlet is wrong because the content inline contradicts
it. The packages for a DSP happen in paralell series, as the page shows; the
portlet can never be 100% right.

== Rules ==

    * Remove the portlet since the correct information is inline.

== QA ==

    * Visit https://edge.launchpad.net/ubuntu/+source/kde4libs
    * Verify that there is no latest release port among the side portlets.

== Lint ==

Linting changed files:
  lib/lp/registry/stories/distribution/xx-distribution-packages.txt
  lib/lp/registry/templates/distributionsourcepackage-index.pt

== Test ==

Describe test additions, changes, and even tests that must run unchanged.

    * lib/lp/registry/stories/distribution/xx-distribution-packages.txt
      * Deleted the test for the portlet

== Implementation ==

    * lib/lp/registry/templates/distributionsourcepackage-index.pt
      * Deleted the inlined portlet.

Revision history for this message
Barry Warsaw (barry) wrote :

Looks good, thanks for cleaning this up.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/registry/stories/distribution/xx-distribution-packages.txt'
--- lib/lp/registry/stories/distribution/xx-distribution-packages.txt 2009-11-07 00:16:01 +0000
+++ lib/lp/registry/stories/distribution/xx-distribution-packages.txt 2009-11-07 22:29:12 +0000
@@ -268,6 +268,7 @@
268 Urgency:* Low Urgency268 Urgency:* Low Urgency
269 Component:* main269 Component:* main
270 Architectures:* any270 Architectures:* any
271 Latest upload: 1.0
271 *actual publishing details may vary in this distribution, these are just the package defaults.272 *actual publishing details may vary in this distribution, these are just the package defaults.
272273
273And if the source has direct packaging linkage, the upstream's description274And if the source has direct packaging linkage, the upstream's description
@@ -304,7 +305,7 @@
304-------------------------------------305-------------------------------------
305306
306The page has a side-bar with a global actions menu, a "Get Involved"307The page has a side-bar with a global actions menu, a "Get Involved"
307menu, a "Latest release" portlet and a "Bug subscriptions" portlet.308menu, and a "Bug subscriptions" portlet.
308309
309 >>> print extract_text(310 >>> print extract_text(
310 ... find_tag_by_id(user_browser.contents, 'global-actions'))311 ... find_tag_by_id(user_browser.contents, 'global-actions'))
@@ -319,13 +320,6 @@
319 Ask a question320 Ask a question
320321
321 >>> print extract_text(322 >>> print extract_text(
322 ... find_tag_by_id(user_browser.contents, 'latest-release'))
323 Latest release
324 Version: 1.0
325 Uploaded by: Mark Shuttleworth
326 On date: ...
327
328 >>> print extract_text(
329 ... find_tag_by_id(user_browser.contents,323 ... find_tag_by_id(user_browser.contents,
330 ... 'portlet-structural-subscribers'))324 ... 'portlet-structural-subscribers'))
331 Bug subscriptions325 Bug subscriptions
332326
=== modified file 'lib/lp/registry/templates/distributionsourcepackage-index.pt'
--- lib/lp/registry/templates/distributionsourcepackage-index.pt 2009-11-07 00:16:01 +0000
+++ lib/lp/registry/templates/distributionsourcepackage-index.pt 2009-11-07 22:29:12 +0000
@@ -23,22 +23,6 @@
2323
24 <tal:involved replace="structure context/@@+get-involved" />24 <tal:involved replace="structure context/@@+get-involved" />
2525
26 <tal:current define="current context/currentrelease">
27 <div class="portlet" id="latest-release" tal:condition="current">
28 <h2>Latest release</h2>
29 <dl>
30 <dt>Version:</dt>
31 <dd><a tal:content="current/version"
32 tal:attributes="href current/fmt:url">3.2.1-3</a>
33 </dd>
34 <dt>Uploaded by:</dt>
35 <dd><a tal:replace="structure current/creator/fmt:link">Foo Bar</a></dd>
36 <dt>On date:</dt>
37 <dd tal:content="current/dateuploaded/fmt:datetime"/>
38 </dl>
39 </div>
40 </tal:current>
41
42 <tal:subscribers26 <tal:subscribers
43 replace="structure context/@@+portlet-structural-subscribers"/>27 replace="structure context/@@+portlet-structural-subscribers"/>
44</tal:side>28</tal:side>
@@ -92,7 +76,7 @@
92 <dt>Urgency:<sup>*</sup></dt>76 <dt>Urgency:<sup>*</sup></dt>
93 <dd tal:content="current/urgency/title"/>77 <dd tal:content="current/urgency/title"/>
94 </dl>78 </dl>
95 <dl>79 <dl style="clear:both">
96 <dt>Component:<sup>*</sup></dt>80 <dt>Component:<sup>*</sup></dt>
97 <dd tal:content="current/component/name"/>81 <dd tal:content="current/component/name"/>
98 </dl>82 </dl>
@@ -100,6 +84,12 @@
100 <dt>Architectures:<sup>*</sup></dt>84 <dt>Architectures:<sup>*</sup></dt>
101 <dd tal:content="current/architecturehintlist"/>85 <dd tal:content="current/architecturehintlist"/>
102 </dl>86 </dl>
87 <dl style="clear:both">
88 <dt>Latest upload:</dt>
89 <dd><a tal:content="current/version"
90 tal:attributes="href current/fmt:url">3.2.1-3</a>
91 </dd>
92 </dl>
103 </div>93 </div>
104 <p style="font-size: 80%;">94 <p style="font-size: 80%;">
105 <sup>*</sup>actual publishing details may vary in this distribution, these are just the package defaults.95 <sup>*</sup>actual publishing details may vary in this distribution, these are just the package defaults.