Launchpad itself

Merge lp:~sinzui/launchpad/webkit-css into lp:launchpad

  1. webkit-css
  2. Merge into devel
Proposed by Curtis Hovey
Status: Merged
Merged at revision: not available
Proposed branch: lp:~sinzui/launchpad/webkit-css
Merge into: lp:launchpad
Diff against target: 172 lines (+23/-50)
7 files modified
lib/canonical/launchpad/icing/style-3-0.css (+19/-1)
lib/canonical/launchpad/icing/style.css (+0/-16)
lib/lp/bugs/templates/bugtarget-bugs.pt (+0/-2)
lib/lp/bugs/templates/bugtask-edit.pt (+0/-9)
lib/lp/bugs/templates/bugtask-view.pt (+0/-18)
lib/lp/bugs/templates/cveset-all.pt (+0/-4)
lib/lp/registry/templates/object-timeline-graph.pt (+4/-0)
To merge this branch: bzr merge lp:~sinzui/launchpad/webkit-css
Reviewer Review Type Date Requested Status
Brad Crittenden (community) code Approve
Review via email: mp+16388@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Curtis Hovey (sinzui) wrote :
Download full text (3.9 KiB)

This is my branch fix the CSS rules for webkit and remove obsolete styles.

    lp:~sinzui/launchpad/webkit-css
    Diff size: 168
    Launchpad bug: https://bugs.launchpad.net/bugs/498574
                   https://bugs.launchpad.net/bugs/498581
                   https://bugs.launchpad.net/bugs/435768
                   https://bugs.launchpad.net/bugs/185306
    Test command: None.
    Pre-implementation: danilo/bac for 1, salgado for 2, beuno 3. no one 4.
    Target release: 3.1.13

= fix the CSS rules for webkit =

Bug #498574 [page layout broken in webkit]
    The CSS rules needed by webkit were broken when the obsolete CSS was
    removed from style-3.0.css--something was not obsolete.

Bug #498581 [restore the timeline stylesheet]
    The timeline was broken in a recent landing because the CSS was removed.
    It was loading the wrong CSS file. It needs the new CSS macro to center
    the timeline and fix zoom in / zoom out.

Bug #435768 [footer font size is too large "This site is running ..."]
    The "This site is running pre-release code ..." message is 13px, but the
    rest of the footer is 11px. This may be fixable by removing the styles so
    that re default styles of the footer takes precedence.

Bug #185306 [portlets, portlets_one, and portlets_two slots are redundant]
    These slots are not used by base-layout, they are not being used.

== Rules ==

Bug #498574 [page layout broken in webkit]
    Restore one of the old #maincontent rules.

Bug #498581 [restore the timeline stylesheet]
    Use the new stylesheet macro to fix the formatting of the timeline
    elements that are created by the script.

Bug #435768 [footer font size is too large "This site is running ..."]
    Remove the font-size instruction.

Bug #185306 [portlets, portlets_one, and portlets_two slots are redundant]
    Remove the unused slots.

== QA ==

Bug #498574 [page layout broken in webkit]
    * View a project page in gecko and webkit and verify that both pages
      show the portlets in the correct place to the right.

Bug #498581 [restore the timeline stylesheet]
    * View a project.
      * Verify the timeline content is centered in its portlet.
      * Verify you see the zoom control when your mouse is over the timeline.

Bug #435768 [footer font size is too large "This site is running ..."]
    * View any page on edge or staging
      * Verify that the site message is the same size as the tour text.

Bug #185306 [portlets, portlets_one, and portlets_two slots are redundant]
    * None, the content is not used.

== Lint ==

Lint reported an obsolete slot in a bug template I was looking at. I removed
all occurrences of the pageheading and portlet slots from main-template.pt
(which was removed last month).

Linting changed files:
  lib/canonical/launchpad/icing/style-3-0.css
  lib/canonical/launchpad/icing/style.css
  lib/lp/bugs/templates/bugtarget-bugs.pt
  lib/lp/bugs/templates/bugtask-edit.pt
  lib/lp/bugs/templates/bugtask-view.pt
  lib/lp/bugs/templates/cveset-all.pt
  lib/lp/registry/templates/object-timeline-graph.pt

== Test ==

None. This changes are visual, or in the case of obsolete content, not
visual.

== Implementation ==

   ...

Read more...

Revision history for this message
Brad Crittenden (bac) wrote :

Curtis thanks for this branch and thanks for taking the time to work with me as we tried to identify the problems. Glad we got it figured out and you discovered the dastardly 'em' problem.

The changes look good to me and they seem to behave properly in Safari and Webkit.

review: Approve (code)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/canonical/launchpad/icing/style-3-0.css'
--- lib/canonical/launchpad/icing/style-3-0.css 2009-12-12 03:25:27 +0000
+++ lib/canonical/launchpad/icing/style-3-0.css 2009-12-21 23:19:13 +0000
@@ -5,9 +5,14 @@
5.yui-t4 .yui-b {5.yui-t4 .yui-b {
6 width: 21%;6 width: 21%;
7 }7 }
8.yui-t4 .yui-main {
9 clear: both;
10 float: left;
11 margin-right: -25%;
12 }
8.yui-t4 .yui-main .yui-b {13.yui-t4 .yui-main .yui-b {
9 width: auto;14 width: auto;
10 margin-right: 24%;15 margin-right: 25%;
11 }16 }
12.footer {17.footer {
13 clear: both;18 clear: both;
@@ -29,6 +34,10 @@
29.footer .lp-arcana .search-icon {34.footer .lp-arcana .search-icon {
30 background: url(icon-sprites) 100% -191px no-repeat;35 background: url(icon-sprites) 100% -191px no-repeat;
31 }36 }
37.footer .sitemessage {
38 text-align: right;
39}
40
32.footer .colophon {41.footer .colophon {
33 margin: 3em 3em 1em 3em;42 margin: 3em 3em 1em 3em;
34 text-align: center;43 text-align: center;
@@ -782,6 +791,15 @@
782 padding: 1em 1em 1em 0;791 padding: 1em 1em 1em 0;
783}792}
784793
794/* Timeline Graph */
795div.yui-timelinegraph-content .yui-timelinegraph-zoom-box {
796 visibility: hidden;
797}
798
799div.yui-timelinegraph-content:hover .yui-timelinegraph-zoom-box {
800 visibility: visible;
801}
802
785/* == Sprites == */803/* == Sprites == */
786.sprite {804.sprite {
787 padding: 2px 0 5px 18px;805 padding: 2px 0 5px 18px;
788806
=== modified file 'lib/canonical/launchpad/icing/style.css'
--- lib/canonical/launchpad/icing/style.css 2009-12-16 19:59:06 +0000
+++ lib/canonical/launchpad/icing/style.css 2009-12-21 23:19:13 +0000
@@ -472,13 +472,6 @@
472472
473/* === Universal page layout === */473/* === Universal page layout === */
474474
475/* All pages include the sitemessage in the footer if one is defined
476 in the config. */
477.sitemessage {
478 font-size: 13px;
479 text-align: right;
480}
481
482/* === Login control === */475/* === Login control === */
483/* At the top right of the page is a link to log in or a button to log out: */476/* At the top right of the page is a link to log in or a button to log out: */
484#logincontrol {477#logincontrol {
@@ -822,15 +815,6 @@
822 margin-top: 1em;815 margin-top: 1em;
823}816}
824817
825/* Timeline Graph */
826div.yui-timelinegraph-content .yui-timelinegraph-zoom-box {
827 visibility: hidden;
828}
829
830div.yui-timelinegraph-content:hover .yui-timelinegraph-zoom-box {
831 visibility: visible;
832}
833
834.product.series, .series {margin-bottom: 1em;}818.product.series, .series {margin-bottom: 1em;}
835#packages h1, #projects h1 {margin-top: 1.2em;}819#packages h1, #projects h1 {margin-top: 1.2em;}
836820
837821
=== modified file 'lib/lp/bugs/templates/bugtarget-bugs.pt'
--- lib/lp/bugs/templates/bugtarget-bugs.pt 2009-11-26 17:28:13 +0000
+++ lib/lp/bugs/templates/bugtarget-bugs.pt 2009-12-21 23:19:13 +0000
@@ -13,8 +13,6 @@
13 <script type="text/javascript" src="/+icing/FormatAndColor.js"></script>13 <script type="text/javascript" src="/+icing/FormatAndColor.js"></script>
14 <script type="text/javascript" src="/+icing/PlotKit_Packed.js"></script>14 <script type="text/javascript" src="/+icing/PlotKit_Packed.js"></script>
15 </metal:block>15 </metal:block>
16 <metal:portlets fill-slot="portlets">
17 </metal:portlets>
18 <body>16 <body>
19 <tal:side metal:fill-slot="side">17 <tal:side metal:fill-slot="side">
20 <div id="involvement" class="portlet involvement">18 <div id="involvement" class="portlet involvement">
2119
=== modified file 'lib/lp/bugs/templates/bugtask-edit.pt'
--- lib/lp/bugs/templates/bugtask-edit.pt 2009-09-08 09:25:58 +0000
+++ lib/lp/bugs/templates/bugtask-edit.pt 2009-12-21 23:19:13 +0000
@@ -10,15 +10,6 @@
10 i18n:domain="malone"10 i18n:domain="malone"
11>11>
12 <body>12 <body>
13 <metal:heading fill-slot="pageheading">
14 <div>
15 <tal:icon replace="structure context/image:icon" />
16 <a tal:attributes="href context/fmt:url"
17 >Bug #<tal:bug replace="context/bug/id">3252543</tal:bug></a>:
18 </div>
19 <h1 tal:content="context/bug/title">Foo doesn't work</h1>
20 </metal:heading>
21
22 <div metal:fill-slot="main">13 <div metal:fill-slot="main">
23 <p tal:condition="view/is_question" class="error message">14 <p tal:condition="view/is_question" class="error message">
24 This bug was converted into a question. It cannot be edited.15 This bug was converted into a question. It cannot be edited.
2516
=== modified file 'lib/lp/bugs/templates/bugtask-view.pt'
--- lib/lp/bugs/templates/bugtask-view.pt 2009-09-08 09:25:58 +0000
+++ lib/lp/bugs/templates/bugtask-view.pt 2009-12-21 23:19:13 +0000
@@ -8,24 +8,6 @@
8 metal:use-macro="view/macro:page/main_only"8 metal:use-macro="view/macro:page/main_only"
9>9>
10 <body>10 <body>
11 <metal:heading fill-slot="pageheading">
12 <div>
13 <img alt="" src="/@@/bug" />
14 <a tal:attributes="href context/bug/fmt:url"
15 >Bug #<tal:bug replace="context/bug/id">3252543</tal:bug></a>:
16 </div>
17 <h1 tal:content="context/bug/title">Foo doesn't work</h1>
18 </metal:heading>
19
20 <metal:leftportlets fill-slot="portlets_one">
21 <div tal:replace="structure context/@@+portlet-status-details" />
22 </metal:leftportlets>
23
24 <metal:rightportlets fill-slot="portlets_two">
25 <div tal:replace="structure context/@@+portlet-search" />
26 <div tal:replace="structure context/@@+portlet-alsoreportedin" />
27 </metal:rightportlets>
28
29 <div metal:fill-slot="main">11 <div metal:fill-slot="main">
30 <p tal:condition="context/bug/duplicateof" class="informational message">12 <p tal:condition="context/bug/duplicateof" class="informational message">
31 This bug is a duplicate of13 This bug is a duplicate of
3214
=== modified file 'lib/lp/bugs/templates/cveset-all.pt'
--- lib/lp/bugs/templates/cveset-all.pt 2009-09-10 09:30:59 +0000
+++ lib/lp/bugs/templates/cveset-all.pt 2009-12-21 23:19:13 +0000
@@ -10,10 +10,6 @@
10 i18n:domain="malone"10 i18n:domain="malone"
11>11>
12 <body>12 <body>
13 <metal:heading fill-slot="pageheading">
14 <h1>All registered CVEs</h1>
15 </metal:heading>
16
17<div metal:fill-slot="main"13<div metal:fill-slot="main"
18 tal:define="batchnav view/getAllBatched;14 tal:define="batchnav view/getAllBatched;
19 batch batchnav/currentBatch">15 batch batchnav/currentBatch">
2016
=== modified file 'lib/lp/registry/templates/object-timeline-graph.pt'
--- lib/lp/registry/templates/object-timeline-graph.pt 2009-12-16 19:59:06 +0000
+++ lib/lp/registry/templates/object-timeline-graph.pt 2009-12-21 23:19:13 +0000
@@ -13,6 +13,10 @@
13 use-macro="context/@@+base-layout-macros/load-javascript" />13 use-macro="context/@@+base-layout-macros/load-javascript" />
14 <metal:lp-client-cache14 <metal:lp-client-cache
15 use-macro="context/@@+base-layout-macros/lp-client-cache" />15 use-macro="context/@@+base-layout-macros/lp-client-cache" />
16
17 <metal:launchpad-stylesheet
18 use-macro="context/@@+base-layout-macros/launchpad-stylesheet-3-0" />
19
16</head>20</head>
1721
18<body style="margin: 0; padding: 0">22<body style="margin: 0; padding: 0">