Code review comment for lp:~thumper/launchpad/edit-commit-msg-link

On Fri, 27 Nov 2009 16:37:59 Michael Hudson wrote:
> Review: Abstain
> All the interesting stuff is Javascript, which I don't really feel
> competent to review :( It looks fine, but I don't know anything about our
> coding standards really.
>
> I'm not sure that the block starting:
>
> + <div id="commit-message" class="yui-g">
> + <tal:no-commit-message condition="not: context/commit_message">
>
> Can't be better factored, but it's TAL so maybe not.

No it can't really, there are several bits that follow.

  reviewer launchpad