Launchpad itself

Merge lp:~barry/launchpad/434072-spec-index into lp:launchpad

  1. 434072-spec-index
  2. Merge into devel
Proposed by Barry Warsaw
Status: Merged
Approved by: Brad Crittenden
Approved revision: no longer in the source branch.
Merged at revision: not available
Proposed branch: lp:~barry/launchpad/434072-spec-index
Merge into: lp:launchpad
Diff against target: None lines
To merge this branch: bzr merge lp:~barry/launchpad/434072-spec-index
Reviewer Review Type Date Requested Status
Brad Crittenden (community) release-critical Approve
Aaron Bentley (community) Approve
Review via email: mp+12175@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Barry Warsaw (barry) wrote :

 reviewer abentley

= Summary =

Very simple conversion of specifications-index.pt
(i.e. http://blueprints.launchpad.* +index page) to UI 3.0.

== Proposed fix ==

Convert the template, update the test, move the label from the template to the
view.

== Pre-implementation notes ==

None. I can do these in my sleep.

== Implementation details ==

Nothing special. This will be an RC.

== Tests ==

bin/test -vv -t stories/blueprints

== Demo and Q/A ==

http://blueprints.launchpad.dev

= Launchpad lint =

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/blueprints/stories/blueprints/xx-index.txt
  lib/lp/blueprints/browser/specification.py
  lib/lp/blueprints/templates/specifications-index.pt

== Pyflakes notices ==

lib/lp/blueprints/browser/specification.py
    56: 'smartquote' imported but unused

Craptastic. I'll fix this before landing.

== Pylint notices ==

lib/lp/blueprints/browser/specification.py
    56: [W0611] Unused import smartquote

Revision history for this message
Aaron Bentley (abentley) wrote :

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

 review approve

Looks straightforward.

Barry Warsaw wrote:
> Barry Warsaw has proposed merging lp:~barry/launchpad/434072-spec-index into lp:launchpad/devel.
>
> Requested reviews:
> Aaron Bentley (abentley)
>
> reviewer abentley
>
> = Summary =
>
> Very simple conversion of specifications-index.pt
> (i.e. http://blueprints.launchpad.* +index page) to UI 3.0.
>
>
> == Proposed fix ==
>
> Convert the template, update the test, move the label from the template to the
> view.
>
>
> == Pre-implementation notes ==
>
> None. I can do these in my sleep.
>
>
> == Implementation details ==
>
> Nothing special. This will be an RC.
>
>
> == Tests ==
>
> bin/test -vv -t stories/blueprints
>
>
> == Demo and Q/A ==
>
> http://blueprints.launchpad.dev
>
>
> = Launchpad lint =
>
> Checking for conflicts. and issues in doctests and templates.
> Running jslint, xmllint, pyflakes, and pylint.
> Using normal rules.
>
> Linting changed files:
> lib/lp/blueprints/stories/blueprints/xx-index.txt
> lib/lp/blueprints/browser/specification.py
> lib/lp/blueprints/templates/specifications-index.pt
>
>
> == Pyflakes notices ==
>
> lib/lp/blueprints/browser/specification.py
> 56: 'smartquote' imported but unused
>
> Craptastic. I'll fix this before landing.
>
>
> == Pylint notices ==
>
> lib/lp/blueprints/browser/specification.py
> 56: [W0611] Unused import smartquote
>
>
>

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkq3uz4ACgkQ0F+nu1YWqI3oRQCePFSp5gqgarTjnDsSEa0BUEXL
gDUAnj1r9aun84pnGDbN38TGs+UtYmwC
=+og7
-----END PGP SIGNATURE-----

review: Approve
Revision history for this message
Brad Crittenden (bac) :
review: Approve (release-critical)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'lib/lp/blueprints/browser/specification.py'
--- lib/lp/blueprints/browser/specification.py 2009-09-19 08:58:42 +0000
+++ lib/lp/blueprints/browser/specification.py 2009-09-21 17:21:57 +0000
@@ -1206,6 +1206,8 @@
1206class SpecificationSetView(AppFrontPageSearchView, HasSpecificationsView):1206class SpecificationSetView(AppFrontPageSearchView, HasSpecificationsView):
1207 """View for the Blueprints index page."""1207 """View for the Blueprints index page."""
12081208
1209 label = 'Blueprints'
1210
1209 @safe_action1211 @safe_action
1210 @action('Find blueprints', name="search")1212 @action('Find blueprints', name="search")
1211 def search_action(self, action, data):1213 def search_action(self, action, data):
12121214
=== modified file 'lib/lp/blueprints/stories/blueprints/xx-index.txt'
--- lib/lp/blueprints/stories/blueprints/xx-index.txt 2009-05-11 18:19:21 +0000
+++ lib/lp/blueprints/stories/blueprints/xx-index.txt 2009-09-21 17:21:57 +0000
@@ -1,4 +1,6 @@
1= Blueprints index page =1=====================
2Blueprints index page
3=====================
24
3The blueprints index page allows users to search for blueprints within5The blueprints index page allows users to search for blueprints within
4a single Launchpad project or across all projects.6a single Launchpad project or across all projects.
@@ -7,6 +9,7 @@
79
8 >>> user_browser.open('http://blueprints.launchpad.dev/')10 >>> user_browser.open('http://blueprints.launchpad.dev/')
9 >>> print extract_text(find_main_content(user_browser.contents))11 >>> print extract_text(find_main_content(user_browser.contents))
12 Blueprints
10 All projects...13 All projects...
11 Recently registered14 Recently registered
12 The Krunch Desktop Plan15 The Krunch Desktop Plan
1316
=== modified file 'lib/lp/blueprints/templates/specifications-index.pt'
--- lib/lp/blueprints/templates/specifications-index.pt 2009-07-17 17:59:07 +0000
+++ lib/lp/blueprints/templates/specifications-index.pt 2009-09-21 17:21:57 +0000
@@ -3,13 +3,9 @@
3 xmlns:tal="http://xml.zope.org/namespaces/tal"3 xmlns:tal="http://xml.zope.org/namespaces/tal"
4 xmlns:metal="http://xml.zope.org/namespaces/metal"4 xmlns:metal="http://xml.zope.org/namespaces/metal"
5 xmlns:i18n="http://xml.zope.org/namespaces/i18n"5 xmlns:i18n="http://xml.zope.org/namespaces/i18n"
6 xml:lang="en"6 metal:use-macro="view/macro:page/main_only"
7 lang="en"
8 dir="ltr"
9 metal:use-macro="view/macro:page/applicationhome"
10 i18n:domain="launchpad">7 i18n:domain="launchpad">
11 <body>8 <body>
12 <h1 metal:fill-slot="heading">Blueprint tracking</h1>
13 <div metal:fill-slot="main">9 <div metal:fill-slot="main">
1410
15 <ul class="buttons">11 <ul class="buttons">