Code review comment for lp:~jamalta/launchpad/newtag-statement-redundancy

Revision history for this message
Jamal Fanaian (jamalta) wrote :

= Summary =

The message 'The tag "[tagname]" hasn't yet been used by [targetname] before. Is this a new tag?' is redundant and misleading. "Yet" and "before" should not are redundant in the statement. From bug 106924 and bug 87058.

== Proposed fix ==

Replace statement with 'The tag "[tagname]" hasn't been used by [targetname] before. (Create the new tag)'

== Pre-implementation notes ==

Spoke with bac to confirm the language that should be used to fix the issue.

== Tests ==

% bin/test -vvct xx-bug-edit

== Demo and Q/A ==

* https://bugs.launchpad.dev/firefox/+bug/1/+edit
  Enter "new-tag" as a tag and click Change

== Launchpad lint ==

Checking for conflicts. and issues in doctests and templates.
Running jslint, xmllint, pyflakes, and pylint.
Using normal rules.

Linting changed files:
  lib/lp/bugs/browser/bug.py
  lib/lp/bugs/stories/bugs/xx-bug-edit.txt

== Pylint notices ==

lib/lp/bugs/browser/bug.py
    28: [F0401] Unable to import 'email.MIMEMultipart' (No module named MIMEMultipart)
    29: [F0401] Unable to import 'email.MIMEText' (No module named MIMEText)
    43: [F0401] Unable to import 'lazr.enum' (No module named enum)
    44: [F0401] Unable to import 'lazr.lifecycle.event' (No module named lifecycle)
    45: [F0401] Unable to import 'lazr.lifecycle.snapshot' (No module named lifecycle)
    46: [F0401] Unable to import 'lazr.restful.interfaces' (No module named restful)

Confirmed that the lint notices are not related to my branch by gary_poster in #launchpad-dev

« Back to merge proposal